kosmorro/CONTRIBUTING.md

Contributing to Kosmorro

If you are reading this, then you are probably looking for a way to contribute to Kosmorro (you’re in the good place!). Thank you! There are multiple ways to contribute that can match with your possibilities.

Opening issues

Reporting bugs

If you found a bug, please check it is not already reported in the Issues tab. If it is not, create a bug report and fill in the template that offers to you. Feel free to give as much information as possible, as it will make the bug easier to fix.

Suggest a new feature

Have an idea of feature you think would be nice on Kosmorro? Time to suggest it! First, please check someone didn’t suggest your next revolution in the Issues tab. If it’s not, create a feature request and fill in the templace that offers to you.

Translating

If you speak another language than English, another nice way to enhance Kosmorro is to translate its messages. The recommended way to begin translating Kosmorro is to join the POEditor team.

Writing code

First of all, if you are fixing an opened issue, check that nobody is already working on it — if someone seems to be but their Pull Request seems stuck, please ask them first if you can continue the development. If you retake the code they produced, don’t change the author of the commits.

Before writing the code, first create a fork of the repository and clone it. You may also want to add the original repository (Deuchnord/kosmorro), so you can update your fork with the last upstream commits.

Then create a new branch and start coding. Finally, commit and push, then open a PR on this project. If your project is not complete, feel free to open it as Draft (if you forgot to activate the Draft status, just edit the first comment to say it), then mark it as ready for review when you’re done.

Choosing the right target branch

Whatever you are doing, always base your working branch on master. When you create your PR, please consider selecting the right target branch:

• If you are fixing a bug or optimizing something, then target the master branch.
• If you are doing anything else, then target the feature branch.

This allows to make easier to publish patch releases, which have a higher priority than the minor releases.

Dealing with the translations

The messages file contains all the messages Kosmorro can display, in order to make them translatable. When you change code, you may change also the messages displayed by the software.

When you add a new string that will be displayed to the end user, please pass it to the _() function made available in the kosmorrolib.i18n package, for instance:

# Dont:
print('Note: All the hours are given in UTC.')

# Do:
from kosmorrolib.i18n import _
print(_('Note: All the hours are given in UTC.'))

This will allow Python’s internationalization tool to translate the string in any available language.

Once you have done your work, please remember to tell Babel to extract the new strings:

$ pipenv run python setup.py extract_messages --output-file=kosmorrolib/locales/messages.pot

If the setup.py script tells you that the extract_messages command does not exist, then run kosmorro sync to ensure all the dev dependencies are installed and try again.

Note that if you forget to update the messages file, the CI will fail.

Matching the coding standards

Kosmorro’s source code follows the major coding standards of Python (PEPs). Before marking your Pull Request as ready for review, don’t forget to check that the code respects the coding standards with PyLint (it is run on the CI, but feel free to run it on your local machine too). Your PR must have a global note of 10/10 to be elligible to merge.

Testing the code

There are two kinds of tests on this project: unit tests and end-to-end tests (sometimes abbreviated to E2E tests).

Unit tests

Unit tests check that every little piece of code (any unit) does exactly what it is supposed to do. They have several advantages, like proving that new things in the codebase works exactly as they should, and making sure that future changes done later won’t break them.

Kosmorro’s unit tests use Python’s official unittest module. They live in the /test folder of the repository. Whenever you write a new feature or a bug fix, please write the unit tests that will make sure it works. You can also run them by invoking the following command:

pipenv run python -m unittest test

Note: there are currently some memory leaks in the unit tests, making the result quite difficult to read. I am working to fix this. If you have troubles reading them, feel free to ask.

End-to-end tests

If unit tests are really good at checking that every individual parts of code work well, they fail at checking that so does the whole program as a finished product. That is the job of end-to-end tests.

The goal here is to make sure that if you install Kosmorro from scratch, it will work without any problem. If a mandatory dependency has not been installed, or if something goes wrong in the main program (which is not possible to unit test), the E2E tests will fail.

Kosmorro’s 2E2 tests are a Bash script living in the /.scripts/tests-e2e.sh file. You should only add tests here if you add new ways to interact with Kosmorro itself (e.g. adding a new argument in the command line).

Fore security purpose, it is not recommended running E2E tests locally, because some tests need the root privilege to pass (e.g. installing optional dependencies). They are run on the CI.

Commiting

The commit messages of this project follow the Conventional Commits Specification: basically, when you commit your changes, please prefix them with the following:

• fix: if your changes fix a bug;
• feat: if your changes add a new feature.

The message of your commit must start with a lowercase. Finally, if your change introduce a BC-break, add a footer beginning with BREAKING CHANGE: and explaining precisely the BC-break.

Once your PR is ready to review, please squash your commits so it contains only one commit.

To ensure your commits follow this convention, you can use glint.

The commit messages are then used to generate the changelog using conventional-changelog:

conventional-changelog -p angular -i CHANGELOG.md -s

Licensing and Copyright Attribution

When you open a Pull Request to the project, you agree to license your code under the GNU Affero General Public License version 3.