From 761ec4ef21b95473829672d69320330f52d1890b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Deuchnord?= Date: Sat, 8 Jan 2022 22:48:58 +0100 Subject: [PATCH] fix: make the opposition detection more reliable (#39) --- kosmorrolib/events.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kosmorrolib/events.py b/kosmorrolib/events.py index 46f5e35..e1c84fb 100644 --- a/kosmorrolib/events.py +++ b/kosmorrolib/events.py @@ -153,6 +153,9 @@ def _search_oppositions(start_time: Time, end_time: Time, timezone: int) -> [Eve >>> _search_oppositions(get_timescale().utc(2021, 3, 20), get_timescale().utc(2021, 3, 21), 0) [] + + >>> _search_oppositions(get_timescale().utc(2022, 12, 24), get_timescale().utc(2022, 12, 25), 0) + [] """ earth = get_skf_objects()["earth"] sun = get_skf_objects()["sun"] @@ -187,7 +190,7 @@ def _search_oppositions(start_time: Time, end_time: Time, timezone: int) -> [Eve times, _ = find_discrete(start_time, end_time, is_oppositing) for time in times: - if get_angle(time) < 0: + if int(get_angle(time)) != 180: # If the angle is negative, then it is actually a false positive. # Just ignoring it. continue